Remove NDTP protocol implementation #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDTP (Neural Data Transport Protocol) was used for on-the-wire serialization but is no longer needed as data is now transmitted via protobuf messages (BroadbandFrame, SpikeFrame). - Remove ndtp.pyx Cython implementation and ndtp_types.py - Remove Cython/crcmod build dependencies from setup.py - Add simplified types.py with dataclasses for internal node communication - Update imports in nodes to use new types module - Remove NDTP tests (no longer applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
types.pywith dataclasses for internal node-to-node communicationTest plan
pip install .works without Cython